[RFC] add HydrationFactory as extension point for tracking hydrations

[kbond]

(Continuation of #12059)

This is a proposed extension point to help solve doctrine/DoctrineBundle#109. I'm thinking a HydratorInterface that AbstractHydrator implements should be added but wanted to get some feedback/input before going further.

The doctrine bundle could use this to add hydration times to the timeline:

The doctrine bundle could add something similar to https://github.com/debesha/DoctrineProfileExtraBundle#screenshots to the profiler panel.

You can see an example of how this could be used in DoctrineBundle here: https://github.com/kbond/symfony-reproducer/tree/hydration-profiler-poc (specifically kbond/symfony-reproducer@9a4e91b).

I don't think this causes any performance problems for hydration (when using the DefaultHydratorFactory).

[greg0ire]

How about having a HydrationObserver abstraction instead, that would be called at well-defined points? It would have two methods, one for the start of the hydration, and one for its end. We could provide a null implementation to avoid if checks.

[beberlei]

How about having a HydrationObserver abstraction instead, that would be called at well-defined points? It would have to methods, one for the start of the hydration, and one for its end. We could provide a null implementation to avoid if checks.

I am also not happy about a factory with the main use case being "only" logging of timings.

An observer would be extra api, maybe a Hydration Start and Completed event as long as they dont allow changing things.

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.