Replace static Type::* calls with instance-based TypeRegistry lookups#12421
Open
GromNaN wants to merge 2 commits into
Open
Replace static Type::* calls with instance-based TypeRegistry lookups#12421GromNaN wants to merge 2 commits into
Type::* calls with instance-based TypeRegistry lookups#12421GromNaN wants to merge 2 commits into
Conversation
All internal callers now resolve types through Configuration::getTypeRegistry() rather than the global static Type::getType() / Type::hasType() / Type::getTypeRegistry() methods. Remaining static calls are justified fallbacks: - Configuration::getTypeRegistry() falls back to Type::getTypeRegistry() for DBAL v3 compatibility (no Configuration::getTypeRegistry() there) - LengthFunction and CountFunction: getReturnType() has no EM access, accessing built-in INTEGER type only - DatabaseDriver: deprecated class, no EM access available
GromNaN
changed the title
Type::* calls with instance-based TypeRegistry lookupsType::* calls with instance-based TypeRegistry lookups
… methods Replace getType()/hasType() helpers with a $typeRegistry property initialized in the constructor, avoiding repeated getConfiguration()->getTypeRegistry() chain calls.
This was referenced Apr 3, 2026
Open
Member
This indicates a flaw in the architecture IMO. If |
Contributor
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to doctrine/dbal#7342
All internal callers now resolve types through
Configuration::getTypeRegistry()rather than the global staticType::getType()/Type::hasType()/Type::getTypeRegistry()methods.Remaining static calls are justified fallbacks:
Configuration::getTypeRegistry()falls back toType::getTypeRegistry()for DBAL v3 and 4.0 compatibility (noConfiguration::getTypeRegistry()there)LengthFunctionandCountFunction:getReturnType()has no EM access, accessing built-inINTEGERtype onlyDatabaseDriver: deprecated class, no EM access available