[RFC] Expose EntityRepository::expr()

[VincentLanglet]

Previously

$qb = $this->createQueryBuilder();
$qb
      ->select('u')
      ->from('User', 'u')
      ->where($qb->expr()->eq('u.id', 1));

Now

$this
     ->createQueryBuilder()
      ->select('u')
      ->from('User', 'u')
      ->where($this->expr()->eq('u.id', 1));

I know we could write

$this
     ->createQueryBuilder()
      ->select('u')
      ->from('User', 'u')
      ->where($this->getEntityManager()->getExpressionBuilder()->eq('u.id', 1));

but that's a little more complicated and people are used to the expr syntax (they might not even not it's called an ExpressionBuilder).

[greg0ire]

Sounds good to me. Are there docs or tests that could be simplified?

[greg0ire]

Suggested change

	protected function expr(): Expr
	final protected function expr(): Expr

[VincentLanglet]

Sounds good to me. Are there docs or tests that could be simplified?

I checked and no:

• docs are about queryBuilder->expr, none of this code is in the EntityRepository context
• tests are testing querybuilder without being in an EntityRepository context too

[VincentLanglet]

I saw "Missing test" was added ; but not sure what should be written for such a basic method added.