Conversation
2 tasks
malarzm
force-pushed
the
malarzm-patch-1
branch
from
27cf31f to
58677c2
Compare
Member
beberlei
added a commit
that referenced
this pull request
Mar 15, 2020
…8006 (#8036) * Add test case * Treat parent embeddables as mapped superclasses * [GH-8031] Bugfix: Get working again on nested embeddables in inherited embeddables. * Housekeeping: CS * Update note on limitations * [GH-8031] Verify assocations still do not work with Embeddables. * Housekeeping: CS Co-authored-by: Benjamin Eberlei <kontakt@beberlei.de>
Member
|
hi. I believe that this change makes sense, but it broke JMS serializer (see schmittjoh/JMSSerializerBundle#790). How can we now distinguish if a class can be managed by the entity manager? |
Member
Author
|
@goetas I believe the question should be "How can we now distinguish if a class should be loaded from db?" and the answer would be then "Check if something is an embeddable through $metadata->isEmbeddedClass" :) |
Member
|
ok :) thanks! |
beberlei
added a commit
to beberlei/doctrine2
that referenced
this pull request
May 12, 2020
…change doctrine#8006 (doctrine#8036)" This reverts commit a9b6b72.
beberlei
added a commit
that referenced
this pull request
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this was an oversight during original implementation but let's see what tests will tell us. Also this made PHPStan ignore Embeddables (phpstan/phpstan-doctrine#108 (review))