add: option to include combined document url for get submission #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, the query parameter
?include=combined_document_urlcan be used to ensure acombined_document_urlis returned (as long as the document has been completed). Without it, it is null until someone manually triggers the creation (e.g. by downloading the combined PDF).For embedded services, this flag may be required and cannot be used with the current API. In this PR I merely added it as a flag for the specific GET submissions function. This could also be implemented more generalized by e.g. allowing additional function parameters for supplying arbitrary query parameters.