All FS ops are POST (wrong method) - #101
Merged
Merged
Conversation
All filesystem operations submit asynchronous task and return TaskSubmitResponse. Using GET/DELETE is semantically wrong. POST is the correct method.
Contributor
Author
|
API Validation Failure is expected, as the official spec is not updated to use POST. |
Contributor
|
This is for v2 right? Seems like maybe a lot of work for users for semantic correctness? I'd let the group decide if it's worth the effort. |
Contributor
|
After discussion on the call this Thursday, this is fine for V2. Any chance at getting a test update to go with this? |
Contributor
Author
|
I had a quick look, and there are 2 issues:
I will create a separate issue for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All filesystem operations submit asynchronous task and return TaskSubmitResponse. Using GET/DELETE is semantically wrong. POST is the correct method.