Skip to content

All FS ops are POST (wrong method) - #101

Merged
pmrich merged 1 commit into
doe-iri:mainfrom
juztas:post-methods
Jun 19, 2026
Merged

All FS ops are POST (wrong method)#101
pmrich merged 1 commit into
doe-iri:mainfrom
juztas:post-methods

Conversation

@juztas

@juztas juztas commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

All filesystem operations submit asynchronous task and return TaskSubmitResponse. Using GET/DELETE is semantically wrong. POST is the correct method.

All filesystem operations submit asynchronous task and return TaskSubmitResponse. Using GET/DELETE is semantically wrong. POST is the correct method.
@juztas

juztas commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

API Validation Failure is expected, as the official spec is not updated to use POST.

@gabor-lbl

Copy link
Copy Markdown
Contributor

This is for v2 right? Seems like maybe a lot of work for users for semantic correctness? I'd let the group decide if it's worth the effort.

@pmrich

pmrich commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

After discussion on the call this Thursday, this is fine for V2.

Any chance at getting a test update to go with this?

@juztas

juztas commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

I had a quick look, and there are 2 issues:

  1. Directory restructure broke validation: doe-iri/iri-facility-api-docs@6465796 (had a quick chat with John; we need to agree on the structure for the docs repo). The docs repo acts as the " source of truth" for validation;
  2. Update v2 spec (after 1 is done) to use POST
  3. Update schemathesis validation to use the new structure (1, 2), and also update validation runtime (GitHub action) to include tests for v1/v2

I will create a separate issue for this

@pmrich
pmrich merged commit 1fda773 into doe-iri:main Jun 19, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants