Fixed infinite loop in workaroundUITextInputTraitsPropertiesBug#71
Open
oxling wants to merge 2 commits intodomesticcatsoftware:masterfrom
Open
Fixed infinite loop in workaroundUITextInputTraitsPropertiesBug#71oxling wants to merge 2 commits intodomesticcatsoftware:masterfrom
oxling wants to merge 2 commits intodomesticcatsoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, if classes were traversed in a particular order, the class's superclass would already have had
valueForKeyswizzled. In that case,originalValueForKeywould be set toUITextInputTraits_valueForKey. This leads to an infinite loop inUITextInputTraits_valueForKey.The fix is to traverse the class's heritage until a suitable
valueForKey:implementation is found.