Conversation
manu1080
commented
Oct 2, 2025
manu1080
commented
- Clean cart_v1
- Update
davidmolinacano
requested changes
Oct 2, 2025
davidmolinacano
requested changes
Oct 2, 2025
Contributor
davidmolinacano
left a comment
davidmolinacano
left a comment
There was a problem hiding this comment.
composer.phar should not be here, this should be installed globally 🤔
sonic182
requested changes
Oct 2, 2025
Member
sonic182
left a comment
sonic182
left a comment
There was a problem hiding this comment.
remove all doc/**/*.html, if it is auto-generated, do not commit it. if in a future we use github pages (which I doubt) a GH CI and another page will build it
sonic182
force-pushed
the
manu1080/doofinder-lib/clean_cart
branch
from
2113716 to
87f32a0
Compare
addUsername
approved these changes
Oct 3, 2025
Member
|
Remember to upload new version to https://packagist.org/packages/doofinder/doofinder you may ask @JoeZ99 to know how |
Member
Ahem @JoeZ99 here What I do remember is studying it, and figuring out how to do it in 30 minutes or so 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.