-
Notifications
You must be signed in to change notification settings - Fork 13
Improving- Getting Started on dora-rs.ai (Part 1 of 4):Python Conversation #28 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @Shiv-aurora , I was going through the Getting Started tutorial and it was not very clear, so I started writing a PR to fix it but I saw that you've already started that! I like what you have so far. A few questions/comments: In "1. Setting Up the Environment"When I run the setup commands you have listed in your PR,
this is what I get:
But I don't get that venv error when I run what's currently on the tutorial:
Maybe keep what's currently on the tutorial? In "2. Creating a New Conversation"You have In creating a new project, it looks like by default, there are 3 nodes that are created: Maybe you could tell people to look at these nodes and then create a new node In "3. Adding Nodes to the Conversation" and "4. Understanding Node Functionality"You seem to imply that
I think that the person taking the tutorial has to add the line In "6. Building and Running the Conversation"It says "You should see output in the terminal similar to:" but I get a whole bunch of log printouts, see here (I did a slightly different example with talker/listener, but same idea): https://app.warp.dev/block/4g1upQKgPQfz5J7CzYHsPi Maybe it would also be nice to say "after running for a bit, you can stop the run using Ctrl/Cmd+C. You'll see a folder called I want to note that I am new to Dora so I might not be correct in my assumptions, but I thought I'd share my thoughts, at the very least I can be like a beta-tester for your updated Getting Started guide. Lmk what you think! Maybe @haixuanTao has thoughts too? |
|
||
```python | ||
|
||
from dora import Node | ||
|
||
def main(): | ||
|
||
node = Node() | ||
|
||
for event in node: | ||
|
||
if event["type"] == "INPUT": | ||
|
||
print(f"Listener received: {event['value'][0].as_py()}") | ||
|
||
if __name__ == "__main__": | ||
|
||
main() | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't the formatting looks weird as there is spaces everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I believe previously I added that to make it look less cluttered, Should i go ahead and remove those? and is there anything else that needs to be improvement?
Bumping my comment. Perhaps I'm just missing something but even if so, others who want to get started might also benefit from clarification. |
@haixuanTao I accidentally deleted the previous PR while syncing my fork, but I have restored it and fixed the issue. Let me know if any further changes are needed.
Changes:
This is Part 1 of 4 in fully resolving dora-rs/dora#885. Suggestions and feedback are highly appreciated to ensure consistency before proceeding with the remaining parts!