Replaced setup.py with pyproject.toml #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves issue dorna-robotics#11. For reasons I do not understand, the setup.py-based installer ("pip install .") fails to access numpy, even if it has just been installed ("pip install -r requirements.txt") and is provably present in the python environment. This patch fixes the problem by replacing "setup.py" and "requirements.txt" with a new "pyproject.toml" that contains the same information. Now, a simple "pip install ." works as expected, both in a plain virtual environment (tested with Python 3.12.3 on Ubuntu 24.04) and in a conda environment (tested with Python 3.13 and PyCharm 25.06 on Windows 11).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #11.
For reasons I do not fully understand, the setup.py-based installer ("pip install .") fails to access numpy, even if it has just been installed ("pip install -r requirements.txt") and is provably present in the python environment.
This patch fixes the problem by replacing "setup.py" and "requirements.txt" with a new "pyproject.toml" that contains the same information. Now, a simple "pip install ." works as expected, both in a plain virtual environment (tested with Python 3.12.3 on Ubuntu 24.04) and in a conda environment (tested with Python 3.13 and PyCharm 25.06 on Windows 11).