Split large unions over multiple lines #10219
Conversation
|
|
Hi @benjie , would there be a scenario where the existing behaviour (i.e. the equivalent of |
|
@eddeee888 Thanks for asking! I would 100% be in support of adding this without a config option. I don't know why anyone would want it all on one line, I was just trying to minimize codegen diff for people who didn't opt in. |
|
It's going to be a little while before I can make that change - feel free to take over, or leave it for me in a few weeks time 👍 |
|
@eddeee888 I've incorporated your feedback and made it so that it uses nice formatting for a lot of the unions. This caused a lot of tests to fail, so I've patched your |
|
Thank you @benjie ! I'll take a look at soon! |
| noSchemaStitching: true, | ||
| useIndexSignature: true, | ||
| namespacedImportName: 'Types', | ||
| printFieldsOnNewLines: true, |
There was a problem hiding this comment.
I'm think we don't have this option anymore?
| await validate(content, config, complexTestSchemaWithUnionsAndInterfaces); | ||
| }); | ||
|
|
||
| it('should extract types from multiple fragments (preResolveTypes: false, printFieldsOnNewlines: true)', async () => { |
There was a problem hiding this comment.
Another printFieldsOnNewLines I could find, this is the last one I believe!
|
I'll merge first and remove the |
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
✔️ Acknowledged. Think of this as the issue, to open the discussion via demonstration.
Please ignore whitespace changes when reviewing this PR.
Description
To make
gitmanagement of changes easier, it's nice if lines aren't too long. Some of the lines emitted by graphql-code-generator can be excessively large which results in hard to review diffs. This PR aims to introduce newline splits in a few more places to make changes more surgical.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tests have been updated.
Test Environment:
masterbranchChecklist:
Notes:
TypeScript GraphQL Request tests › works without variablesandTypeScript GraphQL Request tests › returns first 3 entriestests fail locally for me onmaster. I have not investigated.Further comments
I've currently gated this behind the
printFieldsOnNewLinessetting which seems related; I don't know if you'd want separate settings for each change, or a more generaluseNewlinesForUnionssetting, or...?This is also not an exhaustive change that adds newlines to all unions.