[XABT] Move additional provider source code generation out of <GenerateMainAndroidManifest> task.
#10127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
dev/jpobst/additional-providers
branch
2 times, most recently
from
bbc7b8d to
d2bacc0
Compare
…ateMainAndroidManifest>` task.
jpobst
force-pushed
the
dev/jpobst/additional-providers
branch
from
d2bacc0 to
e0d8a61
Compare
src/Xamarin.Android.Build.Tasks/Utilities/MarshalMethodCecilAdapter.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Utilities/MarshalMethodCecilAdapter.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tasks/GenerateMainAndroidManifest.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tasks/GenerateAdditionalProviderSources.cs
Outdated
Show resolved
Hide resolved
jonathanpeppers
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the process of generating additional provider source code out of the
<GenerateMainAndroidManifest>task into a new<GenerateAdditionalProviderSources>task.Additionally, move the Cecil data needed for this task into the Cecil-less
NativeCodeGenStateObjectclass to help facilitate a future where we aren't using Cecil in the_GenerateJavaStubstarget.