[tests] improve assertions in CancelRequestViaProxy()
#10671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is flaky, but it currently has a terrible error message as "1":
Mono.Android.NET_Tests, Xamarin.Android.NetTests.AndroidMessageHandlerIntegrationTests.HttpClientIntegrationTestBase.CancelRequestViaProxy / Debug
Error message
1
Stack trace
at Xamarin.Android.NetTests.HttpClientIntegrationTestBase.CancelRequestViaProxy() in /Users/runner/work/1/s/tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/HttpClientIntegrationTests.cs:line 166
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Let's improve the assertion message, in general, and that might help
diagnose the flakiness in the future.
This shouldn't alter the behavior of the test, just the assertion message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is flaky, but it currently has a terrible error message as "1":
Let's improve the assertion message, in general, and that might help diagnose the flakiness in the future.
This shouldn't alter the behavior of the test, just the assertion message.