[build] Disable debug spew from the localizer #10673
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local builds would generate hundreds (nearly 700) of messages
similar to these:
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //$schema
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //$schema
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //$schema
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //$schema
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //$schema
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //$schema
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: Adding into localizable strings: //author
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: Adding into localizable strings: //author
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: Adding into localizable strings: //author
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: Adding into localizable strings: //author
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //classifications
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //classifications
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //classifications
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //identity
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: Adding into localizable strings: //author
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: Adding into localizable strings: //author
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: Adding into localizable strings: //name
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //classifications
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: The following element in the template.json will not be included in the localizations because it does not match any of the rules for localizable elements: //classifications
Microsoft.TemplateEngine.TemplateLocalizer.Core.TemplateStringExtractor: Adding into localizable strings: //description
Disable the localizer for local builds, run it only on CI.
Comment on lines
-27
to
30
| <ItemGroup Condition=" '$(RunningOnCI)' != 'true' "> | ||
| <ItemGroup Condition=" '$(RunningOnCI)' == 'true' "> | ||
| <PackageReference Include="Microsoft.TemplateEngine.Authoring.Tasks" Version="$(MicrosoftTemplateEngineAuthoringTasksPackageVersion)" PrivateAssets="all" IsImplicitlyDefined="true" /> | ||
| </ItemGroup> |
Member
There was a problem hiding this comment.
I was reviewing what @pjcollins wrote on how this would work:
I think the need is to checkin the files -- maybe we could make $(LocalizeTemplates) blank by default and you set to to true to opt in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local builds would generate hundreds (nearly 700) of messages similar to these:
Disable the localizer for local builds, run it only on CI.
Pull Request
title and
description
should follow the
commit-messages.mdworkflow documentation, and in particular should include: