[ci] Fail build if any untracked files written in git tree#9939
Merged
Conversation
4439559 to
862bd2b
Compare
862bd2b to
6fc2a70
Compare
pjcollins
approved these changes
Apr 19, 2025
jonpryor
reviewed
Apr 21, 2025
| src/native/CMakePresets.json | ||
| src/native/clr/host/generate-pinvoke-tables | ||
| src/native/clr/host/pinvoke-tables.include.generated | ||
| src/native/mono/pinvoke-override/generate-pinvoke-tables |
Contributor
There was a problem hiding this comment.
@grendello: is it safe to ignore changes to these files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #9661
Building on #9661, we also shouldn't be writing build artifacts to the source tree.
Any files generated by the build should be placed in
/binor/objfolders rather than the source tree.Violations fixed by putting the artifact in
.gitignore.Current violations:
Mac:
Linux:
Windows