Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add Windows 'DebuggingTest' job #9951

Merged
merged 33 commits into from
Mar 25, 2025
Merged

[ci] Add Windows 'DebuggingTest' job #9951

merged 33 commits into from
Mar 25, 2025

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Mar 21, 2025

A new Intel based Windows pool has been configured to run Android
emulator test jobs on. This pool currently has capacity to scale up to
10 agents.

The StartAndroidEmulator task and the execution environment for the
AcquireAndroidTarget target have been updated to address issues with
emulator launch attempts hanging on these Windows VMs with this
seemingly related output:

The STDIO streams did not close within 10 seconds of the exit event from process 'C:\Program Files\dotnet\dotnet.exe'. This may indicate a child process inherited the STDIO streams and has not yet exited.

A new "Windows > Tests > Debugging" job has been added to the MSBuild
Device tests stage that currently runs all tests in the DebuggingTest
category.

Starting with only one new job will allow us to start to scale up on
Windows while monitoring for potential performance/reliabilty issues.

@pjcollins pjcollins marked this pull request as ready for review March 24, 2025 20:06
@pjcollins pjcollins requested a review from jonpryor as a code owner March 24, 2025 20:06
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, it makes sense for this lane to show up here:

image

Comment on lines -156 to -160
p.OutputDataReceived += WriteProcessOutputMessage;
p.ErrorDataReceived += WriteProcessErrorMessage;

p.BeginOutputReadLine ();
p.BeginErrorReadLine ();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, was it specifically these lines that made Run() never return on Windows?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this seemed to fix things in CI, though I never had this issue when running locally on Windows strangely enough

@pjcollins pjcollins merged commit ad86668 into main Mar 25, 2025
57 of 59 checks passed
@pjcollins pjcollins deleted the dev/pjc/win-emu branch March 25, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants