Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements the new codeflows page UI, replacing mock data with real API calls and restructuring the table to show forward flow and backflow as separate rows per repository with color-coded status indicators.
Changes:
- Replaced mock data with real
PcsApi.Codeflow.GetCodeflowStatusesAsynccalls, with VMR default channel discovery - Restructured the data grid from one row per repo (with separate backflow/forward columns) to two rows per repo (one per direction) using a
CodeflowRowrecord - Added traffic-light status indicators (green/yellow/red dots) for build staleness and PR age
Comment on lines
+240
to
245
| var statuses = await PcsApi.Codeflow.GetCodeflowStatusesAsync( | ||
| branch: _branch, | ||
| repositoryUrl: _defaultChannel.Repository); | ||
|
|
||
| CodeFlowRows = ToRows(statuses) | ||
| .AsQueryable(); |
| "https://github.com/dotnet/dotnet", | ||
| "https://github.com/maestro-auth-test/dotnet", | ||
| "https://github.com/maestro-auth-test/dnceng-vmr", | ||
| ]; |
Comment on lines
+291
to
+302
| ]; | ||
|
|
||
| foreach (var vmrUri in possibleVmrs) | ||
| { | ||
| var defaultChannels = await PcsApi.DefaultChannels.ListAsync(repository: vmrUri); | ||
|
|
||
| if (defaultChannels.Count > 0) | ||
| { | ||
| return defaultChannels | ||
| .OrderByDescending(c => c.Branch == "main") | ||
| .ThenByDescending(c => c.Branch) | ||
| .ToList(); |
premun
reviewed
Mar 16, 2026
|
|
||
| <GridViewTemplate Title="Codeflows1234" ShowSkeleton="CodeFlows == null"> | ||
| <!--<Header> | ||
| <GridViewTemplate Title="Codeflows" ShowSkeleton="CodeFlowRows == null"> |
Member
There was a problem hiding this comment.
I am not sure if we want to have a dedicated row for backflow/forward flow. For instance, if you sort the table by last flow:
- It's unclear which it is sorting based on
- It can also make the two co-joined rows go apart and then the table stops making sense:
Instead, if we keep those on a single row, we can get rid of the direction column which can give us enough space to show both backflow/forward flow in a single row.
If the table is still too big, we can work around the long grey text with build age and make it shorter maybe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5929 (comment)