Remove InternalsVisibleTo and add new projects to slnx#6115
Merged
premun merged 1 commit intodotnet:mainfrom Mar 23, 2026
Merged
Remove InternalsVisibleTo and add new projects to slnx#6115premun merged 1 commit intodotnet:mainfrom
premun merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up cleanup to #6112 to undo an accidental change by removing unnecessary InternalsVisibleTo entries and ensuring the new shared CLI projects are included in the repo’s main solution filter (.slnx).
Changes:
- Removed
InternalsVisibleTodeclarations fromTools.Cli.Common.csproj. - Added
Tools.Cli.CommonandTools.Cli.Coreprojects toarcade-services.slnx.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/Tools.Cli.Common/Tools.Cli.Common.csproj | Removes friend-assembly exposure that referenced non-existent/unused assemblies. |
| arcade-services.slnx | Includes the new shared CLI projects in the main solution configuration. |
You can also share your feedback on Copilot code review. Take the survey.
dkurepa
approved these changes
Mar 23, 2026
premun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup for #6112 which merged by mistake