Revert "Update NuGet global packages cache detection" #14874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-purma
approved these changes
Jun 20, 2024
|
@sharwell we need to urgently flow arcade so I am reverting your changes until you have a fix |
sharwell
reviewed
Jun 20, 2024
| <!-- Respect environment variable for the NuGet Packages Root if set; otherwise, use the current default location --> | ||
| <NuGetPackageRoot Condition="'$(NuGetPackageRoot)' != ''">$([MSBuild]::NormalizeDirectory('$(NuGetPackageRoot)'))</NuGetPackageRoot> | ||
| <NuGetPackageRoot Condition="'$(NuGetPackageRoot)' == '' and '$(NUGET_PACKAGES)' != ''">$([MSBuild]::NormalizeDirectory('$(NUGET_PACKAGES)'))</NuGetPackageRoot> | ||
| <NuGetPackageRoot Condition="'$(NuGetPackageRoot)' == '' and '$(OS)' == 'Windows_NT'">$([MSBuild]::NormalizeDirectory('$(UserProfile)', '.nuget', 'packages'))</NuGetPackageRoot> |
There was a problem hiding this comment.
My system will not load any arcade-based code in Visual Studio or build any arcade-based repo from the command line with this invalid code in place.
|
@sharwell you can possibly:
|
|
@premun Can you clarify how to perform step (3)? |
|
In |
sharwell
added a commit
to sharwell/arcade
that referenced
this pull request
Jun 21, 2024
This reverts commit a1cd79a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14763