-
Notifications
You must be signed in to change notification settings - Fork 704
fade apphost logs, put dashboard/codespaces in green in console #12262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fade apphost logs, put dashboard/codespaces in green in console #12262
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12262Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12262" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the console output experience when running Aspire apps by styling apphost logs with a faded appearance and displaying dashboard/codespaces URLs in green in the console. The changes enable passing text styling information through the CLI-to-extension backchannel and apply ANSI escape codes for formatting.
Key changes:
- Added
textStyleparameter to the backchannel message writing pipeline to support ANSI escape codes - Applied dim styling (
\x1b[2m) to apphost logs and green styling (\x1b[32m) to dashboard/codespaces URLs - Conditionally hide dashboard URLs in the CLI UI when running in extension host mode
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.Cli/Interaction/ExtensionInteractionService.cs |
Added textStyle parameter to WriteDebugSessionMessage method signature and forwarded it to the backchannel |
src/Aspire.Cli/Commands/RunCommand.cs |
Applied dim styling to apphost logs, conditionally hid dashboard URLs in extension mode, refactored extension build check into helper method |
src/Aspire.Cli/Backchannel/ExtensionBackchannel.cs |
Added textStyle parameter to RPC method and included it in the method invocation |
extension/src/utils/strings.ts |
Added applyTextStyle utility function to wrap text with ANSI escape codes |
extension/src/server/interactionService.ts |
Applied styling to dashboard messages and integrated applyTextStyle function |
extension/src/loc/strings.ts |
Added localized strings for "Dashboard" and "Codespaces" labels |
extension/package.nls.json |
Added localization entries for dashboard and codespaces strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIP IT 🚢🚢🚢🚢🚢🚢🚢🚢🚢
Description
Fixes #12255
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate