Skip to content

Conversation

@adamint
Copy link
Member

@adamint adamint commented Oct 21, 2025

Description

Fixes #12255

image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 22:14
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12262

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12262"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the console output experience when running Aspire apps by styling apphost logs with a faded appearance and displaying dashboard/codespaces URLs in green in the console. The changes enable passing text styling information through the CLI-to-extension backchannel and apply ANSI escape codes for formatting.

Key changes:

  • Added textStyle parameter to the backchannel message writing pipeline to support ANSI escape codes
  • Applied dim styling (\x1b[2m) to apphost logs and green styling (\x1b[32m) to dashboard/codespaces URLs
  • Conditionally hide dashboard URLs in the CLI UI when running in extension host mode

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Aspire.Cli/Interaction/ExtensionInteractionService.cs Added textStyle parameter to WriteDebugSessionMessage method signature and forwarded it to the backchannel
src/Aspire.Cli/Commands/RunCommand.cs Applied dim styling to apphost logs, conditionally hid dashboard URLs in extension mode, refactored extension build check into helper method
src/Aspire.Cli/Backchannel/ExtensionBackchannel.cs Added textStyle parameter to RPC method and included it in the method invocation
extension/src/utils/strings.ts Added applyTextStyle utility function to wrap text with ANSI escape codes
extension/src/server/interactionService.ts Applied styling to dashboard messages and integrated applyTextStyle function
extension/src/loc/strings.ts Added localized strings for "Dashboard" and "Codespaces" labels
extension/package.nls.json Added localization entries for dashboard and codespaces strings

Copy link
Member

@maddymontaquila maddymontaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT 🚢🚢🚢🚢🚢🚢🚢🚢🚢

@adamint adamint enabled auto-merge (squash) October 22, 2025 15:43
@adamint adamint merged commit 80f248e into dotnet:main Oct 22, 2025
302 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 13.0 milestone Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve debugger output

3 participants