Add a new UseKestel API to the WebApplicationFactory #60635
Merged
+415
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-mvc
|
This is an amazing idea! |
There was a problem hiding this comment.
PR Overview
This PR introduces an alternative design for enabling real server usage with WebApplicationFactory by adding a new API that leverages Kestrel. Key changes include:
- Adding a new test class (RealServerBackedIntegrationTests.cs) that validates the real server integration.
- Introducing a new WebApplicationFactory subclass (KestrelBasedWapFactory.cs) that automatically enables Kestrel.
- Updating the core WebApplicationFactory implementation to conditionally use a Kestrel server versus the traditional TestServer.
Reviewed Changes
| File | Description |
|---|---|
| src/Mvc/test/Mvc.FunctionalTests/RealServerBackedIntegrationTests.cs | New integration tests for real server backed functionality. |
| src/Mvc/test/Mvc.FunctionalTests/KestrelBasedWapFactory.cs | A factory that configures the WebApplicationFactory to use Kestrel. |
| src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs | Modifications to support the new UseKestrel API, including updated server creation, client configuration, and error handling. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Throw if the UseKestrel() is called after server initialization
halter73
reviewed
Mar 5, 2025
src/Mvc/test/Mvc.FunctionalTests/RealServerBackedIntegrationTests.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Mar 5, 2025
halter73
reviewed
Mar 5, 2025
Tratcher
reviewed
Mar 7, 2025
- Allow configuring Kestrel options.
…st startup model.
martincostello
approved these changes
Mar 19, 2025
halter73
reviewed
Mar 24, 2025
halter73
reviewed
Mar 24, 2025
halter73
approved these changes
Mar 28, 2025
|
@Tratcher any last minute suggestions before I merge this? |
|
|
|
Thank you, @halter73, @martincostello and @Tratcher ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseKestrel(...)APIs to the WebApplicationFactory type. The API configures the WAF, so that later during initialization it will use Kestrel, instead of a TestServer for WebHostBuilder-based applications.EnsureServer()private method toStartServer()and made it public, so that consumers can call it directly, without the need of creating a client, as in many situations customers didn't need a client to interact with.This is an alternative design to enabling real server usage with WebApplicationFactory, which was considered here: #60247
Fixes #4892