[release/8.0] Fix preserving messages for stateful reconnect with backplane #61375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-signalr
wtgodbe
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60900 to release/8.0
/cc @BrennanConroy
Fix preserving messages for stateful reconnect with backplane
Description
When using the Redis backplane with SignalR combined with stateful reconnect, messages received from the backplane are not correctly accounted for on the server-side. This means that if the client disconnects and does a stateful reconnect the server will not properly send missed messages and potentially other issues which could result in the connection being disconnected due to server errors.
Fixes #55575
Customer Impact
Stateful reconnect with Redis backplane is essentially broken and should not be used together until fixed.
Regression?
Risk
Added missing E2E test to verify scenario.
Verification
Packaging changes reviewed?