Skip to content

[Blazor] Add preload placeholder to blazorwasm template #61448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

[Blazor] Add preload placeholder to blazorwasm template #61448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3859233
Update index.html
maraf Apr 11, 2025
b9876bc
Merge remote-tracking branch 'upstream/main' into BlazorWasmPreloadPl…
maraf Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ectTemplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/wwwroot/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>ComponentsWebAssembly-CSharp</title>
<base href="/" />
<link rel="preload" id="webassembly" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet-wasm ? dotnet-webassembly ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing the name would require changing the SDK side too. If we don't feel strongly about naming, I think going with webassembly is fine. (It's also more consistent with what we use elsewhere, where we just use webassembly if that helps)

Copy link
Member Author

@maraf maraf Apr 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name already landed in different PR for "hosted" mode.
I probably wouldn't prefer dotnet- prefix as everything here is dotnet.
Whether wasm or webassembly is up for discussion.

<!--#if SampleContent -->
<link rel="stylesheet" href="lib/bootstrap/dist/css/bootstrap.min.css" />
<!--#endif -->
Expand Down
Loading