fetch TLS client hello message from HTTP.SYS #61494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-networking
| internal void InvokeTlsClientHelloCallback(ulong connectionId, IFeatureCollection features, | ||
| Func<IFeatureCollection, TlsClientHelloCallback, bool> invokeTlsClientHelloCallback) | ||
| { | ||
| if (!_connectionTimestamps.TryAdd(connectionId, _timeProvider.GetUtcNow())) |
There was a problem hiding this comment.
Could this be AddOrUpdate?
There was a problem hiding this comment.
No, because it doesn't tell you if you are the thread that created the entry or not in order for us to decide whether to call the callback or not.
Co-authored-by: Aditya Mandaleeka <[email protected]>
adityamandaleeka
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60806
fetch TLS client hello message from HTTP.SYS
Description
Exposes a callback that we'll call with the
byte[]representation of the TLS Client Hello when a connection connects to the server.Fixes #60805
Customer Impact
Allows customers to inspect the TLS Client Hello message for a connection.
Regression?
Risk
Fully opt-in feature so won't affect existing code. Also, if it is turned on, there are a few app context knobs to tweak behavior in case something goes wrong.
Verification
Packaging changes reviewed?