Powderhouse error proposal #2374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanJoeris
reviewed
Apr 16, 2024
| ## API | ||
|
|
||
| * `CliDiagnosticDescriptor` | ||
| *`string DiagnosticId` |
| * `CliError` | ||
| * `public string DiagnosticId` | ||
| * `public Location Location` (which includes Symbol and Text to allow messages to be what user typed) | ||
| * `public string? Message` (defaults to Diagnostic) |
There was a problem hiding this comment.
Unsure but I think you might mean (defaults to DefaultMessage) rather than (defaults to Diagnostic)
Comment on lines
+23
to
+25
| ### `ErrorSubsystem` | ||
|
|
||
| Errors will be managed and reported via the ErrorSubsystem. This is to allow errors to be easily added by any subsystem. This might be preprocessing, execution, or optionally by an uncaught exception. Addition of errors by invocations is supported, to allow consistent reporting of errors. |
There was a problem hiding this comment.
I think this proposal for ErrorSubsystem makes sense. Curious if you think my PR for an initial pass at ErrorSubsystem should be merged first then implement this proposal or vice-versa?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for the shape of Powderhouse errors and an overview of usage.