Add CDAC support to SOS #5392
Merged
Add CDAC support to SOS #5392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --usecdac and --forceusecdac options "runtimes" to control cdac loading. Currently --usecdac enables using the CDAC for only the CLRMA APIs. --forceusecdac forces all SOS to use the CDAC for testing. Move ISettingsService impl's to Host class. Add UseContractReader property. Add IRuntime.GetCDacFilePath() and add a "bool verifySignature" parameter to IRuntime.GetDacFilePath. Add DotNetRuntimeContractDescriptor address to !runtimes info. Clean up the formatting a little. Publish SOS.Hosting package
hoyosjs
reviewed
Apr 2, 2025
src/Microsoft.Diagnostics.DebugServices.Implementation/Runtime.cs
Outdated
Show resolved
Hide resolved
tommcdon
reviewed
Apr 5, 2025
7 tasks
tommcdon
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --usecdac and --forceusecdac options "runtimes" to control cdac loading. Currently --usecdac enables using the CDAC for only the CLRMA APIs. --forceusecdac forces all SOS to use the CDAC for testing.
Move ISettingsService impl's to Host class. Add UseContractReader property.
Add IRuntime.GetCDacFilePath() and add a "bool verifySignature" parameter to IRuntime.GetDacFilePath.
Add DotNetRuntimeContractDescriptor address to !runtimes info. Clean up the formatting a little.
Publish SOS.Hosting package