Stabilize distributed trace pipeline tests - #5958
Draft
hoyosjs wants to merge 2 commits into
Draft
Conversation
Wait for the distributed tracing event handler to be ready before waking the tracee, and wait for activity delivery before stopping the pipeline. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee7094e3-aa37-4474-b595-d1ed5a1d2764
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee7094e3-aa37-4474-b595-d1ed5a1d2764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize distributed trace startup at both ends: register the consumer handler before reporting pipeline startup, then wait in the tracee until
ActivitySource.HasListeners()confirms the runtime installed the EventPipe listener. Keep the pipeline open until the expected activity is consumed.This addresses intermittent empty-collection failures in
TestTracesPipelineandTestTracesPipelineWithSamplingRatio. No breaking changes.Manual stress reproduction hit the original failure once in 10 class runs. The current implementation completed 20 stress iterations across the locally runnable .NET 8-10 cases (120 test cases). The .NET 11 cases require CI because the local SDK cannot build the net11 tracee.