-
Notifications
You must be signed in to change notification settings - Fork 119
Support resetting state when connecting to a previously monitored app #8154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktork
commented
Apr 28, 2025
...Diagnostics.Monitoring.StartupHook/ParameterCapturing/Pipeline/ParameterCapturingPipeline.cs
Show resolved
Hide resolved
wiktork
commented
Apr 28, 2025
wiktork
commented
Apr 28, 2025
wiktork
commented
Apr 28, 2025
wiktork
commented
Apr 28, 2025
wiktork
commented
Apr 28, 2025
src/Microsoft.Diagnostics.Monitoring.StartupHook/Exceptions/Pipeline/ExceptionPipeline.cs
Outdated
Show resolved
Hide resolved
5c9a410
to
c619266
Compare
wiktork
commented
May 2, 2025
jander-msft
reviewed
May 2, 2025
....Diagnostics.Monitoring.StartupHook/Exceptions/CurrentAppDomainFirstChanceExceptionSource.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
May 2, 2025
...ft.Diagnostics.Monitoring.StartupHook/Exceptions/CurrentAppDomainUnhandledExceptionSource.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
May 2, 2025
...ft.Diagnostics.Monitoring.StartupHook/Exceptions/CurrentAppDomainUnhandledExceptionSource.cs
Show resolved
Hide resolved
jander-msft
reviewed
May 2, 2025
src/Microsoft.Diagnostics.Monitoring.StartupHook/Exceptions/Pipeline/ExceptionPipeline.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
May 2, 2025
...Diagnostics.Monitoring.StartupHook/ParameterCapturing/Pipeline/ParameterCapturingPipeline.cs
Show resolved
Hide resolved
jander-msft
reviewed
May 2, 2025
jander-msft
reviewed
May 2, 2025
jander-msft
reviewed
May 2, 2025
03a1971
to
707bb36
Compare
schmittjoseph
previously approved these changes
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off on the parameter capturing + profiler changes. Be sure to add a release notes entry and the relevant PR label
jander-msft
reviewed
May 5, 2025
src/Microsoft.Diagnostics.Monitoring.StartupHook/Exceptions/Pipeline/ExceptionPipeline.cs
Show resolved
Hide resolved
jander-msft
approved these changes
May 5, 2025
jander-msft
previously approved these changes
May 5, 2025
src/Microsoft.Diagnostics.Monitoring.Options/OptionsDisplayStrings.resx
Outdated
Show resolved
Hide resolved
4fa3bb7
to
43ea29f
Compare
jander-msft
previously approved these changes
May 6, 2025
…s threads and pipeline stop calls
Co-authored-by: Justin Anderson <[email protected]>
c61ce14
to
a2c284d
Compare
jander-msft
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Scenario
Dotnet-monitor profiling/exceptions/parameter capture is installed in an application. Then dotnet-monitor is terminated but the application is not. Dotnet-monitor is then restarted and is once again observing the same application.
Startuphook/profiler changes
Command handling
There are 3 threads that handle commands:
Exception reset
Parameters capture reset
Callstacks
TODO:
Release Notes Entry
Added support for resetting in process features when dotnet-monitor is restarted.