Change AIFunction.InvokeAsync to accept AIFunctionArguments #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
requested review from
halter73,
SteveSandersonMS and
eiriktsarpalis
src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Mar 19, 2025
|
@SteveSandersonMS, @halter73, as this is a fundamental change, I'd like a second review before merging. Thanks! |
src/Libraries/Microsoft.Extensions.AI.Abstractions/Functions/AIFunctionArguments.cs
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIRealtimeExtensions.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs
Outdated
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Mar 19, 2025
halter73
approved these changes
Mar 19, 2025
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/FunctionInvokingChatClient.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIRealtimeExtensions.cs
Outdated
Show resolved
Hide resolved
- Adds a new AIFunctionArguments type. - Changes AIFunction.InvokeAsync to accept an AIFunctionArguments instead of an arbitrary enumerable. - Changes FunctionInvokingChatClient to accept an IServiceProvider and expose it as a Services property, and to then pass that IServiceProvider into the AIFunction via AIFunctionArguments.Services. - Augments FunctionInvocationContext with an AIFunctionArguments property. - Changes AIFunctionFactory to special-case parameters of type IServiceProvider and AIFunctionArguments, sourcing from AIFunctionArguments. - Makes AIJsonSchemaCreateOptions a record.
stephentoub
force-pushed
the
aifunctionarguments
branch
from
f5e7c7b to
fe4453c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow