Use Assert.Fail in WebView integration test#286
Open
Redth wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a DevFlow Windows WebView integration test helper to use the analyzer-preferred xUnit assertion API while preserving the existing timeout/fallback behavior.
Changes:
- Replaces
Assert.True(false, message)withAssert.Fail(message)when no WebView contexts are detected within the timeout.
Contributor
|
✅ Expert Code Review: 3 independent reviewers found no issues. Methodology: 3-model adversarial consensus.
|
Member
Author
|
Thanks for the review. No actionable issues were reported, so no changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows DevFlow integration suite passes, but the local run surfaced an xUnit analyzer warning in the WebView integration test helper. This change keeps the test behavior the same while using the analyzer-preferred assertion API.
Summary
Assert.True(false, message)withAssert.Fail(message)inWebViewTests.Testing
DEVFLOW_TEST_PLATFORM=windows dotnet test src\DevFlow\Microsoft.Maui.DevFlow.Agent.IntegrationTests\Microsoft.Maui.DevFlow.Agent.IntegrationTests.csproj- 113/113 passed