[iOS] Added support for large titles in Shell #32081
Open
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces web resource request interception capabilities to the BlazorWebView component and includes extensive localization updates for .NET MAUI template strings. The primary purpose is to enable applications to intercept and customize web resource requests within BlazorWebView controls, while also updating localized template descriptions across multiple languages.
- Adds web resource request interception functionality to BlazorWebView
- Updates BlazorWebView to implement IWebRequestInterceptingWebView interface
- Includes comprehensive localization updates for template strings in multiple languages
Reviewed Changes
Copilot reviewed 293 out of 3888 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BlazorWebView/src/Maui/IBlazorWebView.cs | Extended interface to inherit from IWebRequestInterceptingWebView |
| src/BlazorWebView/src/Maui/BlazorWebView.cs | Added WebResourceRequested event and implementation |
| src/BlazorWebView/src/Maui/Android/WebKitWebViewClient.cs | Enhanced request interception logic with improved logging |
| src/BlazorWebView/src/Maui/Android/BlazorWebViewHandler.Android.cs | Updated Android WebView integration with namespace changes |
| src/BlazorWebView/src/Maui/PublicAPI/*.txt | Added new public API surface for WebResourceRequested event |
| loc//src/Templates/src/templates/ | Updated localized template strings across multiple languages |
src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj
Show resolved
Hide resolved
kubaflo
changed the title
Introduces the UpdateLargeTitles method to manage large title display modes for navigation bars in ShellItemRenderer. This ensures that the large title preference is updated when the displayed page changes or when the view lays out subviews, aligning with iOS-specific platform configurations.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Oct 20, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Introduces the UpdateLargeTitles method to manage large title display modes for navigation bars in ShellItemRenderer. This ensures that the large title preference is updated when the displayed page changes or when the view lays out subviews, aligning with iOS-specific platform configurations.
Issues Fixed
Fixes #12156