Add information about binlog to stdout #12638
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| LogMessage("BinLogFilePath=" + FilePath); | ||
| LogMessage("CurrentUICulture=" + System.Globalization.CultureInfo.CurrentUICulture.Name); | ||
| Console.WriteLine("BinLogFilePath=" + FilePath); | ||
| Console.WriteLine("CurrentUICulture=" + System.Globalization.CultureInfo.CurrentUICulture.Name); |
There was a problem hiding this comment.
Do people need the culture?
As for the binlog, should this be a human readable string? perhaps "Written {0}" or something
There was a problem hiding this comment.
Not sure the culture is needed, I wanted to replicate the message, but I definitely want to make the text localizable and respect the verbosity. This was just a first draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Binlog file is produced if the option
/bl:file.binlogis used when calling MSBuild.Changes Made
Console.writeline(...)addod to the BinarryLogger.cs` to output location and name of the produced binlog file.Testing
Tested manually locally
Notes
Not sure if Console.Writeline is the right approach to print the information, plus the message should be localized. This is draft for now.