Revert "Reduce File I/O under the AnalyzerAssemblyLoader folder (#724… #75761
+123
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
Cosifne
commented
Nov 6, 2024
| @@ -321,7 +295,7 @@ public Assembly LoadFromPath(string originalAnalyzerPath) | |||
| AssemblyName? bestName = null; | |||
| foreach (var candidateOriginalPath in paths.OrderBy(StringComparer.Ordinal)) | |||
| { | |||
| (AssemblyName? candidateName, string candidateRealPath) = GetAssemblyInfoForPath(candidateOriginalPath); | |||
There was a problem hiding this comment.
I keep GetBestPath change from Todd's PR as I see later this method (line 290)
public string? GetOriginalDependencyLocation(AssemblyName assemblyName)
{
CheckIfDisposed();
return GetBestPath(assemblyName).BestOriginalPath;
}
is referencing the BestOriginalPath
jjonescz
approved these changes
Nov 6, 2024
jaredpar
reviewed
Nov 6, 2024
src/Compilers/Core/CodeAnalysisTest/AnalyzerAssemblyLoaderTests.cs
Outdated
Show resolved
Hide resolved
|
Have you done a test insertion with this change to see if there are any noticeable perf regressions? |
ToddGrun
reviewed
Nov 7, 2024
src/Compilers/Core/CodeAnalysisTest/AnalyzerAssemblyLoaderTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #72412 and fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2285967/