Disallow escaping refs to implicit rvalue temporaries #75830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
I would like to know if the approach looks good before I continue (there are several remaining details to be implemented, see the PR description). |
|
Let's try to reach consensus that we want to solve this by adding an error rather than by preventing the temp from being shared. Perhaps we could talk through it in an upcoming compiler team meeting. |
|
Talked with Jared today; I misunderstood the discussion under the issue, we already seem to have reached a consensus to NOT report errors and instead prevent the temps from being reused by the emit layer. (The former would be too big of a break.) I will look into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67435.
TODO: