Emit async-iterators with runtime-async when possible #81314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
force-pushed
the
async-iterator2
branch
4 times, most recently
from
2765f0d to
8542bed
Compare
jcouv
force-pushed
the
async-iterator2
branch
from
8542bed to
cfbdbfb
Compare
stephentoub
reviewed
Nov 26, 2025
| The `GetAsyncEnumerator` method either returns the current instance if it can be reused, | ||
| or creates a new instance of the state machine class. | ||
|
|
||
| Assuming that the unspeakble state machine class is named `Unspeakable`, `GetAsyncEnumerator` is emitted as: |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| Assuming that the unspeakble state machine class is named `Unspeakable`, `GetAsyncEnumerator` is emitted as: | |
| Assuming that the unspeakable state machine class is named `Unspeakable`, `GetAsyncEnumerator` is emitted as: |
|
|
||
| #### Lowering of `yield return` | ||
|
|
||
| `yield return` is disallowed in finally, in try with catch and in catch. |
Member
There was a problem hiding this comment.
Unrelated to this PR, we were going to look at removing some of these restrictions, in particular for yields inside of a try with a catch, right?
|
|
||
| ## Open issues | ||
|
|
||
| Question: AsyncIteratorStateMachineAttribute, or IteratorStateMachineAttribute, or other attribute on kickoff method? |
Member
There was a problem hiding this comment.
Why would this need to differ from what we do today?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to test plan #75960