-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the CPUID and XSAVE logics for APX #104637
base: main
Are you sure you want to change the base?
Changes from 13 commits
9f8f67c
a68865c
6dfb92b
b998cdf
3446e28
9bc008a
44163d7
600abd0
81b47c6
d516feb
42f1729
d90bf49
79b23c8
8e1ba4a
ea8949f
597e797
117c401
8cc7e8e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# APX Integration in .NET | ||
|
||
Let's keep documentation on APX integration and notes on things here. I will evolve this as necessary. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,12 +8,14 @@ | |
#define XSTATE_AVX512_KMASK (5) | ||
#define XSTATE_AVX512_ZMM_H (6) | ||
#define XSTATE_AVX512_ZMM (7) | ||
#define XSTATE_APX (19) | ||
|
||
#define XSTATE_MASK_GSSE (1 << (XSTATE_GSSE)) | ||
#define XSTATE_MASK_AVX (XSTATE_MASK_GSSE) | ||
#define XSTATE_MASK_AVX512 ((1 << (XSTATE_AVX512_KMASK)) | \ | ||
(1 << (XSTATE_AVX512_ZMM_H)) | \ | ||
(1 << (XSTATE_AVX512_ZMM))) | ||
#define XSTATE_MASK_APX (1 << (XSTATE_APX)) | ||
|
||
// The arch bit is normally set in the flag constants below. Since this is already arch-specific code and the arch bit is not | ||
// relevant, the arch bit is excluded from the flag constants below for simpler tests. | ||
|
@@ -91,7 +93,8 @@ | |
#define CONTEXT_KMask0 CONTEXT_Ymm0H+(16*16) | ||
#define CONTEXT_Zmm0H CONTEXT_KMask0+(8*8) | ||
#define CONTEXT_Zmm16 CONTEXT_Zmm0H+(32*16) | ||
#define CONTEXT_Size CONTEXT_Zmm16+(64*16) | ||
#define CONTEXT_Egpr CONTEXT_Zmm16+(16*8) | ||
#define CONTEXT_Size CONTEXT_Egpr+(64*16) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't look right. It seems it should be
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like this comment is still pending. I'd agree with the janvorli's assessment here. Each new define is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for pointing out and the explanation! sorry for the delay, we had a holiday yesterday. |
||
|
||
#else // HOST_64BIT | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc can be added only once there is something worth talking about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can remove this for now and may add some specification to the design when REX2 or APX-EVEX changes coming in.