Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for building with Clang 19 #109198

Open
wants to merge 5 commits into
base: release/8.0-staging
Choose a base branch
from
Open

Add support for building with Clang 19 #109198

wants to merge 5 commits into from
+86 −65

Conversation

MichaelSimons
Copy link
Member

Backport of #105141 to release/8.0
Upstreaming .NET 8.0 Fedora 41 patch

This is required so that source-build can build/test on Fedora 41 (dotnet/source-build#4593).

dotnet-maestro bot and others added 2 commits October 17, 2024 12:21
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20241…
82d4dbf 
…016.1 (dotnet#108947)

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24508.1 -> To Version 8.0.0-beta.24516.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@MichaelSimons
Add support for building with Clang 19
0d5addc
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 24, 2024
@MichaelSimons MichaelSimons mentioned this pull request Oct 24, 2024
Open
am11
am11 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! 👍

@am11 am11 added area-Infrastructure-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 24, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

This was referenced Oct 25, 2024
Open
Open
Open
Open
@omajid
Copy link
Member

omajid commented Oct 25, 2024

I forgot to note it down in my original Fedora patch, but the changes to src/native/libs/CMakeLists.txt are from a different PR: #101871

@build-analysis build-analysis bot mentioned this pull request Oct 25, 2024
Open
@omajid
Copy link
Member

omajid commented Oct 28, 2024

cc @dviererbe who had to use a similar fix on Ubuntu

@dviererbe
Copy link
Contributor

cc @dviererbe who had to use a similar fix on Ubuntu

Correct, we have a patch for Ubuntu >= 24.10. Ubuntu 24.04 uses clang 18 and Ubuntu 22.04 uses clang 14 and therefore does not require the patch.

Nice that this gets backported :)

@dviererbe
Copy link
Contributor

We also have a patch in place for clang 18. Shouldn't this be backported first before adding clang 19 support?

@omajid omajid mentioned this pull request Nov 7, 2024
Open
@MichaelSimons
Copy link
Member Author

We also have a patch in place for clang 18. Shouldn't this be backported first before adding clang 19 support?

You should feel free to open a PR to upstream your patch. I'm not seeing a reason to order the changes.

@MichaelSimons
Copy link
Member Author

@jkoritzinsky, what is the runtime's process for merging infra changes like this? Does this require tactics approval or tell mode?

@jkoritzinsky
Copy link
Member

We usually do tell-mode for infra-only changes. I'm currently OOF, @hoyosjs can you help get this in?

@hoyosjs
Copy link
Member

hoyosjs commented Nov 15, 2024

Is this release 8 only?

@hoyosjs hoyosjs changed the base branch from release/8.0 to release/8.0-staging November 15, 2024 07:01
@hoyosjs hoyosjs added the Servicing-consider Issue for next servicing release review label Nov 15, 2024
@hoyosjs
Copy link
Member

hoyosjs commented Nov 15, 2024

Changing to staging branch seems to have messed this. I'll fix this tomorrow.

@am11
Copy link
Member

am11 commented Nov 15, 2024

Changing to staging branch seems to have messed this. I'll fix this tomorrow.

Usually infra (build related) changes are directly pushed to the release branch (#107921), while product changes go through staging. It's a bit confusing where we draw the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am11 am11 am11 approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@omajid omajid Awaiting requested review from omajid

Assignees

@MichaelSimons MichaelSimons

Labels
area-Infrastructure-coreclr Servicing-consider Issue for next servicing release review
Projects
Runtime Infra
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MichaelSimons @omajid @dviererbe @jkoritzinsky @hoyosjs @am11 @vseanreesermsft