-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Remove WasmFingerprintDotnetJs
tests and add OverrideHtmlAssetPlaceholders
tests
#112859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/mono/wasm/Wasm.Build.Tests/ProjectProviderBase.cs:122
- Uncommenting this debug logging line may clutter the test output during normal runs. Consider gating the logging behind a verbose condition or a flag to keep output clean by default.
_testOutput.WriteLine("Comparing {expectedFilename} with {actualFile}, expectFingerprintOnDotnetJs: {expectFingerprintOnDotnetJs}, expectFingerprint: {expectFingerprint}");
src/mono/wasm/Wasm.Build.Tests/Common/EnvironmentVariables.cs:26
- The environment variable key was changed from 'WASM_FINGERPRINT_DOTNET_JS' to 'USE_DOTNET_FINGERPRINTING_FOR_TESTS'; please ensure that all test configurations and dependent code are updated to reflect this change.
internal static readonly bool UseFingerprintingDotnetJS = Environment.GetEnvironmentVariable("USE_DOTNET_FINGERPRINTING_FOR_TESTS") is "true";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to leave the test output line in the pr?
Yes, I did. Do you think it's too noisy? If it was there, it would have shortened the investigation. I could also collect the text from 122 and print only in line 152, when we for sure throw. |
WasmFingerprintDotnetJs
tests and add WriteImportMapToHtml
tests
WasmFingerprintDotnetJs
tests and add WriteImportMapToHtml
testsWasmFingerprintDotnetJs
tests and add WriteImportMapToHtml
tests
|
After consulting with @maraf, the mapping mechanism needs a small update. This PR should wait until the update is merged to sdk and propagated to WBT. |
Because of the rename we should wait for dotnet/sdk#47915 😬 |
WasmFingerprintDotnetJs
tests and add WriteImportMapToHtml
testsWasmFingerprintDotnetJs
tests and add OverrideHtmlAssetPlaceholders
tests
Fixes #112814.
Blazor does not support running with
WasmFingerprintDotnetJs
- Blazor importsdotnet.js
explicitly and setting this property would break this import. From this reason - remove the WBT testing it from Blazor.Wasm browser apps support
WasmFingerprintDotnetJs
, however, there is an issue connected with running WBT asset apps that hasWasmFingerprintDotnetJs=true
. We cannot load the sources because in WBT we have also explicitruntime/src/mono/wasm/testassets/WasmBasicTestApp/App/wwwroot/main.js
Line 4 in a015e48
in our test app asset, so importing will fail. To keep it simple, we skip testing it there as well.
Add WBT for
WriteImportMapToHtml=true
introduced in Write import map to html files sdk#46233. For both: blazor and browser wasm.Keep the extended logging in case of WBT assert failure.