[clr-interp] Refactor passing of configuration environment variables #114300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
3 tasks
teo-tsirpanis
added
area-CodeGen-Interpreter-coreclr
and removed
needs-area-label
janvorli
reviewed
Apr 7, 2025
This flag adds a `INTOP_BREAKPOINT` instruction at the beginning of the method. This opcode calls the `InterpBreakpoint` method. In order to make use of this debug option, you need to add a breakpoint to this method. An alternative would be to use special instructions to trigger a trap in the debugger, but there is no clean cross platform way to do this currently. Using `__builtin_debugtrap()` on arm64 doesn't allow for step/continue, you would need to set the PC register manually to the next instruction in order to exit the trap, making it a pain to use.
BrzVlad
force-pushed
the
feature-clr-interp5
branch
from
0f12db7 to
cdaacbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
InterpConfigValuesclass that holds all interpreter configuration knobs, in a similar fashion to RyuJIT'sJitConfigValues. Support for method sets was not currently added, meaning that we can pass a single method currently and the match happens by comparing the name only, without support for regex like wildcards.Added
DOTNET_InterpDumpwhich selects the method to have its compilation information dumped.Added
DOTNET_InterpHaltwhich facilitates breaking whenever the method in question starts executing.