Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate Microsoft.CSharp with RequiresDynamicCode #114346

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

agocke
Copy link
Member

@agocke agocke commented Apr 7, 2025

The public API surface looks exactly like RequiresUnreferencedCode, but the private implementation details vary slightly. I don't think there's a meaningful difference in the annotations for RDC vs RUC.

The public API surface looks exactly like RequiresUnreferencedCode, but
the private implementation details vary slightly. I don't think there's a
meaningful difference in the annotations for RDC vs RUC.
@Copilot Copilot bot review requested due to automatic review settings April 7, 2025 19:07
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 64 out of 65 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/libraries/Microsoft.CSharp/src/Microsoft.CSharp.csproj: Language not supported

Copy link
Contributor

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

@agocke agocke requested a review from sbomer April 7, 2025 19:08
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@agocke agocke merged commit 2bd1701 into dotnet:main Apr 8, 2025
83 of 89 checks passed
@agocke agocke deleted the rdc-annotate-dynamic branch April 8, 2025 19:12
MichalStrehovsky added a commit that referenced this pull request Apr 9, 2025
ToolsTests legs are failing: #114406 (comment)
Psychic debugging (without actually trying to repro anything) tells me this is from #114346 that makes us emit more dynamic keyword warnings. That PR didn't trigger the ToolsTests leg since it's not a ILLink change.
MichalStrehovsky added a commit that referenced this pull request Apr 9, 2025
ToolsTests legs are failing: #114406 (comment)
Psychic debugging (without actually trying to repro anything) tells me this is from #114346 that makes us emit more dynamic keyword warnings. That PR didn't trigger the ToolsTests leg since it's not a ILLink change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants