-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate Microsoft.CSharp with RequiresDynamicCode #114346
Conversation
The public API surface looks exactly like RequiresUnreferencedCode, but the private implementation details vary slightly. I don't think there's a meaningful difference in the annotations for RDC vs RUC.
Note regarding the
|
1 similar comment
Note regarding the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 64 out of 65 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/libraries/Microsoft.CSharp/src/Microsoft.CSharp.csproj: Language not supported
Tagging subscribers to this area: @cston |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
ToolsTests legs are failing: #114406 (comment) Psychic debugging (without actually trying to repro anything) tells me this is from #114346 that makes us emit more dynamic keyword warnings. That PR didn't trigger the ToolsTests leg since it's not a ILLink change.
ToolsTests legs are failing: #114406 (comment) Psychic debugging (without actually trying to repro anything) tells me this is from #114346 that makes us emit more dynamic keyword warnings. That PR didn't trigger the ToolsTests leg since it's not a ILLink change.
The public API surface looks exactly like RequiresUnreferencedCode, but the private implementation details vary slightly. I don't think there's a meaningful difference in the annotations for RDC vs RUC.