Skip to content

Implement SVE2 ConvertToSingleOdd and ConvertToSingleRoundToOdd #118957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Nov 11, 2025
Merged

Implement SVE2 ConvertToSingleOdd and ConvertToSingleRoundToOdd #118957

merged 23 commits into from
Nov 11, 2025

Conversation

@SwapnilGaikwad
Copy link
Contributor

@SwapnilGaikwad SwapnilGaikwad commented Aug 21, 2025

Contributes to #94018

@dotnet/arm64-contrib @amanasifkhalid @a74nh

Co-authored-by: @jacob-crawley

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 21, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 21, 2025

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Aug 21, 2025
Open
amanasifkhalid
amanasifkhalid reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some failures in CI to look at: console log.

SwapnilGaikwad
SwapnilGaikwad commented Aug 22, 2025
View reviewed changes
This was referenced Aug 22, 2025
Open
Open
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Aug 29, 2025
Open
3 tasks
@a74nh a74nh mentioned this pull request Sep 1, 2025
Open
@jeffhandley jeffhandley added this to the 11.0.0 milestone Sep 2, 2025
a74nh
a74nh reviewed Sep 2, 2025
View reviewed changes
a74nh
a74nh reviewed Sep 2, 2025
View reviewed changes
tannergooding
tannergooding reviewed Oct 20, 2025
View reviewed changes
tannergooding
tannergooding reviewed Oct 20, 2025
View reviewed changes
@JulieLeeMSFT
Copy link
Member

JulieLeeMSFT commented Oct 20, 2025

@SwapnilGaikwad once you address the feedback from Tanner, our team will do another pass of review.

tannergooding
tannergooding reviewed Oct 22, 2025
View reviewed changes
@SwapnilGaikwad @tannergooding
Improve assert check
da4933a 
Co-authored-by: Tanner Gooding <[email protected]>
@build-analysis build-analysis bot mentioned this pull request Oct 22, 2025
Closed
tannergooding
tannergooding approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SwapnilGaikwad
Copy link
Contributor Author

SwapnilGaikwad commented Oct 23, 2025

@SwapnilGaikwad once you address the feedback from Tanner, our team will do another pass of review.

Hi @JulieLeeMSFT , the failures seem unrelated to this PR (they are x64 only and changes are SVE only). It is now ready for another pass of review.

@JulieLeeMSFT
Copy link
Member

JulieLeeMSFT commented Oct 23, 2025

@EgorBo, PTAL.

@JulieLeeMSFT JulieLeeMSFT requested a review from EgorBo October 23, 2025 21:54
@SwapnilGaikwad
Copy link
Contributor Author

SwapnilGaikwad commented Oct 28, 2025

Hi @EgorBo , the failures on x86 seems unrelated to this change. The changes are SVE only.

EgorBo
EgorBo approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EgorBo EgorBo enabled auto-merge (squash) October 28, 2025 19:28
@SwapnilGaikwad
Copy link
Contributor Author

SwapnilGaikwad commented Nov 7, 2025

Hi @EgorBo, this PR may need a bit of poking to get merged. 🙂

@EgorBo
Copy link
Member

EgorBo commented Nov 7, 2025

Hi @EgorBo, this PR may need a bit of poking to get merged. 🙂

Yeah, our CI is not in a great shape lately 🙁 , let's watch the current CI run

This was referenced Nov 7, 2025
Open
Closed
Open
Open
Open
@EgorBo
Copy link
Member

EgorBo commented Nov 10, 2025

I'll re-run it once we bring CI back to life

@EgorBo
Copy link
Member

EgorBo commented Nov 11, 2025

/ba-g deadletter

@EgorBo EgorBo merged commit f48fbe9 into dotnet:main Nov 11, 2025
150 of 172 checks passed
@build-analysis build-analysis bot mentioned this pull request Nov 11, 2025
Open
3 tasks
@SwapnilGaikwad SwapnilGaikwad deleted the github-sve2-ConvertToSingleOdd branch November 12, 2025 10:16
@dotnet-maestro dotnet-maestro bot mentioned this pull request Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PranavSenthilnathan PranavSenthilnathan PranavSenthilnathan left review comments

@EgorBo EgorBo EgorBo approved these changes

@tannergooding tannergooding tannergooding approved these changes

+2 more reviewers

@amanasifkhalid amanasifkhalid amanasifkhalid left review comments

@a74nh a74nh a74nh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PranavSenthilnathan PranavSenthilnathan

Labels

area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@SwapnilGaikwad @a74nh @JulieLeeMSFT @jeffhandley @EgorBo @tannergooding @PranavSenthilnathan @amanasifkhalid @jacob-crawley