Skip to content

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented Oct 10, 2025

I think we can remove now.

@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 01:50
@VSadov VSadov requested review from agocke and removed request for Copilot October 10, 2025 01:51
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@VSadov
Copy link
Member Author

VSadov commented Oct 10, 2025

Cc: @agocke

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of experimental attribute LGTM

@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 19:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the experimental attribute from async helpers, making them a stable part of the API. The AsyncHelpers class in System.Runtime.CompilerServices is being promoted from experimental status by removing the ExperimentalAttribute and associated warning suppressions.

  • Removes ExperimentalAttribute("SYSLIB5007") from AsyncHelpers class
  • Removes corresponding #pragma warning disable SYSLIB5007 suppressions from test files
  • Updates both the reference assembly and implementation to reflect the stable API status

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.cs Removes ExperimentalAttribute from AsyncHelpers class implementation
src/libraries/System.Runtime/ref/System.Runtime.cs Removes ExperimentalAttribute from AsyncHelpers class in reference assembly
src/tests/async/reflection/reflection-simple.cs Removes SYSLIB5007 warning suppressions around AsyncHelpers usage
src/tests/async/fibonacci-without-yields-config-await/fibonacci-without-yields-config-await.cs Removes SYSLIB5007 warning suppression at file level

@VSadov VSadov enabled auto-merge (squash) October 14, 2025 19:09
@VSadov
Copy link
Member Author

VSadov commented Oct 14, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants