-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[RuntimeAsync] Removing Experimental attribute from async helpers. #120585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @mangod9 |
Cc: @agocke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of experimental attribute LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the experimental attribute from async helpers, making them a stable part of the API. The AsyncHelpers
class in System.Runtime.CompilerServices
is being promoted from experimental status by removing the ExperimentalAttribute
and associated warning suppressions.
- Removes
ExperimentalAttribute("SYSLIB5007")
fromAsyncHelpers
class - Removes corresponding
#pragma warning disable SYSLIB5007
suppressions from test files - Updates both the reference assembly and implementation to reflect the stable API status
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.cs | Removes ExperimentalAttribute from AsyncHelpers class implementation |
src/libraries/System.Runtime/ref/System.Runtime.cs | Removes ExperimentalAttribute from AsyncHelpers class in reference assembly |
src/tests/async/reflection/reflection-simple.cs | Removes SYSLIB5007 warning suppressions around AsyncHelpers usage |
src/tests/async/fibonacci-without-yields-config-await/fibonacci-without-yields-config-await.cs | Removes SYSLIB5007 warning suppression at file level |
Thanks! |
I think we can remove now.