Fixes #104716 marking HttpClient.Send with UnsupportedOSPlatform with values of android, ios over eixisting #120716
+32
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, ios over eixisting
dotnet-policy-service
bot
added
the
community-contribution
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #104716 by adding platform-specific annotations to mark HttpClient.Send methods as unsupported on Android and iOS platforms, in addition to the existing browser platform restriction.
Key changes:
- Added
UnsupportedOSPlatformattributes for "android" and "ios" to synchronous Send methods - Uncommented previously commented-out platform attributes in HttpClientHandler
- Updated both implementation and reference assembly files for consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| HttpMessageInvoker.cs | Added android and ios platform restrictions to the base Send method |
| HttpClientHandler.AnyMobile.cs | Uncommented android and ios platform attributes for the Send method override |
| HttpClient.cs | Added android and ios platform restrictions to all four Send method overloads |
| System.Net.Http.cs | Updated reference assembly to reflect the new platform restrictions |
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Http/ref/System.Net.Http.cs:1
- Corrected malformed attribute name from 'UnsupportedOSPlatformAttributeUnsupportedOSPlatform' to 'UnsupportedOSPlatform'.
// Licensed to the .NET Foundation under one or more agreements.
|
Tagging subscribers to this area: @dotnet/ncl |
accept copilot suggestion to correct UnsupportedOSPlatform attribute name Co-authored-by: Copilot <[email protected]>
ManickaP
reviewed
Oct 21, 2025
| [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")] | ||
| [System.Runtime.Versioning.UnsupportedOSPlatform("android")] | ||
| [System.Runtime.Versioning.UnsupportedOSPlatform("browser")] | ||
| [System.Runtime.Versioning.UnsupportedOSPlatform("ios")] |
There was a problem hiding this comment.
Is there a reason why it doens't also exclude "tvos"?
There was a problem hiding this comment.
@ManickaP
Ok, good catch., thanks!
I will add "tvos" on the unsupportedOSPlatform today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104716 by marking HttpClient.Send with UnsupportedOSPlatform with values of android, ios over eixisting.
Please review.
cc @wfurt , @ManickaP