-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Merging internal commits for release/9.0 #120719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PranavSenthilnathan
merged 13 commits into
dotnet:release/9.0
from
vseanreesermsft:internal-merge-9.0-2025-10-14-1155
Oct 14, 2025
Merged
Merging internal commits for release/9.0 #120719
PranavSenthilnathan
merged 13 commits into
dotnet:release/9.0
from
vseanreesermsft:internal-merge-9.0-2025-10-14-1155
Oct 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-merge-9.0-2025-10-14-1155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds early validation for SMTP SSL/TLS requirements by failing fast when a server doesn't support the EHLO command but SSL is required.
Key Changes
- Added an early check in
SendHello()
to detect and fail when SSL is required but the server falls back to HELO (which doesn't support STARTTLS)
PranavSenthilnathan
approved these changes
Oct 14, 2025
/ba-g #120380 |
35fe9c6
into
dotnet:release/9.0
82 of 86 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.