[release/10.0] Fix localization of links in runtime bundle #120721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes localization of installer links by replacing hardcoded English text with localization tokens. This addresses a regression introduced when the installers moved to WiX 5 in RC2, where localized strings weren't ready at the time.
- Replaces hardcoded English link text with localization tokens for Privacy Statement and EULA links
- Enables proper localization of installer links for different languages
joeloff
approved these changes
Oct 14, 2025
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/runtime/actions/runs/18513328276 |
PranavSenthilnathan
added a commit
that referenced
this pull request
Oct 20, 2025
Backport of #120721 to main /cc @PranavSenthilnathan Links in the installer have English text instead of localized text. See #120109 for screenshots. Found by CTI. Fixes #120109 Co-authored-by: Pranav Senthilnathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
Links in the installer have English text instead of localized text. See #120109 for screenshots. Found by CTI.
Regression
Installers moved to WiX 5 in RC2 and we intentionally took a regression to localization because string weren't localized in time for the release. Now for GA we have all the strings.
Testing
I validated this locally by running the installer using
/lang 3082and verifying that the link is localized.Risk
Low. Localization was already missing.
Fixes #120109