Delete IA64-specific comment and associated code #121226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the jump instruction emission and decoding functions across multiple architectures (amd64, i386, arm, arm64, riscv64, loongarch64, wasm) to eliminate intermediate wrapper functions and consolidate the codebase. The changes rename emitJump and decodeJump to emitBackToBackJump and decodeBackToBackJump directly, removing the historical wrapper layer that was originally designed for IA64 architecture considerations.
Key changes:
- Consolidated
emitJump/decodeJumpandemitBackToBackJump/decodeBackToBackJumpinto single implementations - Removed obsolete IA64-specific comments about back-to-back jump optimization requirements
- Removed unused
GetAnyThunkTargetstub implementations from ARM64, RISCV64, and LoongArch64 architectures
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/amd64/cgenamd64.cpp | Consolidated isJumpRel32, isJumpRel64, decodeJump32, decodeJump64 into unified isBackToBackJump and decodeBackToBackJump; renamed emitJump to emitBackToBackJump; removed obsolete comment |
| src/coreclr/vm/amd64/cgencpu.h | Updated function declarations to use consolidated emitBackToBackJump, isBackToBackJump, and decodeBackToBackJump; removed inline wrapper implementations |
| src/coreclr/vm/i386/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations and obsolete IA64 comment |
| src/coreclr/vm/arm/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations and obsolete IA64 comment |
| src/coreclr/vm/arm64/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations |
| src/coreclr/vm/arm64/stubs.cpp | Removed unused GetAnyThunkTarget stub implementation |
| src/coreclr/vm/riscv64/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations |
| src/coreclr/vm/riscv64/stubs.cpp | Removed unused GetAnyThunkTarget stub implementation |
| src/coreclr/vm/loongarch64/cgencpu.h | Renamed emitJump to emitBackToBackJump and decodeJump to decodeBackToBackJump; removed wrapper implementations |
| src/coreclr/vm/loongarch64/stubs.cpp | Removed unused GetAnyThunkTarget stub implementation |
| src/coreclr/vm/wasm/cgencpu.h | Removed obsolete IA64-specific comment about back-to-back jump optimization |
| src/coreclr/vm/precode.h | Updated call sites to use isBackToBackJump and decodeBackToBackJump |
| src/coreclr/vm/dynamicmethod.cpp | Updated call site to use emitBackToBackJump |
| src/coreclr/vm/codeman.cpp | Updated call site to use emitBackToBackJump |
Comments suppressed due to low confidence (1)
src/coreclr/vm/amd64/cgenamd64.cpp:496
- The comment references 'emitJump' but this function has been renamed to 'emitBackToBackJump'. Update the comment to:
// emitBackToBackJump may throw
THROWS; // emitBackToBackJump may throw (see emitJump)
jkoritzinsky
approved these changes
Oct 31, 2025
This was referenced Oct 31, 2025
Open
|
/ba-g infrastructure timeouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.