[Wasm RyuJit] codegen for loading a register-sized struct local#126059
Open
AndyAyersMS wants to merge 2 commits intodotnet:mainfrom
Open
[Wasm RyuJit] codegen for loading a register-sized struct local#126059AndyAyersMS wants to merge 2 commits intodotnet:mainfrom
AndyAyersMS wants to merge 2 commits intodotnet:mainfrom
Conversation
Member
Author
|
fyi @dotnet/jit-contrib Fixes SPC debug assert (2) in #125756 (comment) We have a struct-typed use feeding an int-typed store: |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Wasm RyuJit local variable codegen to correctly load “register-sized” struct locals by using an appropriate memory attribute (emitAttr) when emitting the load.
Changes:
- Adjusted load emission to derive
emitAttrfrom the register type when the node isTYP_STRUCT - Added an
assertto catchEA_UNKNOWNattributes before emitting the load
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
This was referenced Mar 25, 2026
Open
kg
approved these changes
Mar 25, 2026
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.