Skip to content

Added SkipLast and TakeLast examples#814

Merged
rpetrusha merged 2 commits intodotnet:stagingfrom
tomzorz:master
Apr 30, 2019
Merged

Added SkipLast and TakeLast examples#814
rpetrusha merged 2 commits intodotnet:stagingfrom
tomzorz:master

Conversation

@tomzorz
Copy link
Copy Markdown
Contributor

@tomzorz tomzorz commented Apr 13, 2019 •
edited
Loading

See Snippet203 and Snippet204

Summary

Describe your changes here.

Part of the fix for dotnet/dotnet-api-docs/issues/2267, dotnet/dotnet-api-docs/issues/1060 and dotnet/dotnet-api-docs/issues/1061.

@tomzorz
SkipLast and TakeLast examples
69f2b21 
See Snippet203 and Snippet204
@tomzorz tomzorz requested a review from BillWagner as a code owner April 13, 2019 19:19
@BillWagner BillWagner added the ✨ 1st-time samples contributor! Indicates PRs from new contributors to the samples repository label Apr 16, 2019
@rpetrusha rpetrusha added this to the April 2019 milestone Apr 16, 2019
rpetrusha
rpetrusha suggested changes Apr 16, 2019
View reviewed changes
Copy link
Copy Markdown

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tomzorz, for contributing to the dotntet/samples repo and for adding examples for Enumerable.SkipLast and Enumerable.TakeLast. Can you add a Visual Basic version of the examples? The source is found at snippets\visualbasic\VS_Snippets_CLR_System\system.Linq.Enumerable\VB\Enumerable.vb.

Were you planning to open a PR in the dotnet/dotnet-api-docs repo to add these examples to the documentation?

@tomzorz
Copy link
Copy Markdown
Contributor Author

tomzorz commented Apr 16, 2019

@rpetrusha I'll add the VB samples, and yes I was - see dotnet/dotnet-api-docs#2267 for details.

@tomzorz
Copy link
Copy Markdown
Contributor Author

tomzorz commented Apr 29, 2019

@rpetrusha I added the vb samples. (I followed the pattern of the other examples in the file.)

@BillWagner BillWagner added the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Apr 30, 2019
@BillWagner
Copy link
Copy Markdown
Member

BillWagner commented Apr 30, 2019

@rpetrusha This is ready for a final review. All changes have been addressed.

@rpetrusha rpetrusha changed the base branch from master to staging April 30, 2019 17:15
@rpetrusha
Copy link
Copy Markdown

rpetrusha commented Apr 30, 2019

Thanks for adding the Visual Basic example, @tomzorz. I'll merge your PR now. The changes will be live on docs.microsoft.com sometime next week.

@rpetrusha rpetrusha merged commit b167e0b into dotnet:staging Apr 30, 2019
@tomzorz
Copy link
Copy Markdown
Contributor Author

tomzorz commented Apr 30, 2019

Excellent, thank you!

Thraka pushed a commit that referenced this pull request May 1, 2019
@tomzorz @Thraka
Added SkipLast and TakeLast examples (#814)
c1cb76f 
* SkipLast and TakeLast examples

See Snippet203 and Snippet204

* added vb SkipLast and TakeLast examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner Awaiting requested review from BillWagner

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tomzorz tomzorz

Labels

changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review ✨ 1st-time samples contributor! Indicates PRs from new contributors to the samples repository

Projects

None yet

Milestone

April 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@tomzorz @BillWagner @rpetrusha