Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick 44859 into release/9.0.2xx: Fix failing tests because of "UseUwpTools" property #44882

Open
wants to merge 1 commit into
base: release/9.0.2xx
Choose a base branch
from
+4 −0
Open

Cherry-pick 44859 into release/9.0.2xx: Fix failing tests because of "UseUwpTools" property #44882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAWindowsDesktopProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,7 @@ public void ItWarnsWhenBuildingAProjectWithUseUwpProperty()
TargetFrameworks = "net9.0-windows10.0.22621.0"
};
testProject.AdditionalProperties["UseUwp"] = "true";
testProject.AdditionalProperties["UseUwpTools"] = "false";

var testAsset = _testAssetsManager.CreateTestProject(testProject);

Expand All @@ -484,6 +485,7 @@ public void ItErrorsWhenTargetingBelowNet6WithUseUwpProperty()
TargetFrameworks = "netstandard2.0"
};
testProject.AdditionalProperties["UseUwp"] = "true";
testProject.AdditionalProperties["UseUwpTools"] = "false";

var testAsset = _testAssetsManager.CreateTestProject(testProject);

Expand All @@ -505,6 +507,7 @@ public void ItErrorsWhenTransitivelyReferencingWindowsUIXamlReferencesWithoutUse
TargetFrameworks = "net9.0-windows10.0.22621.0"
};
testProjectA.AdditionalProperties["UseUwp"] = "true";
testProjectA.AdditionalProperties["UseUwpTools"] = "false";

TestProject testProjectB = new()
{
Expand Down Expand Up @@ -579,6 +582,7 @@ public void ItBuildsWhenReferencingWindowsUIXamlTypesWithUseUwpProperty()
}
};
testProject.AdditionalProperties["UseUwp"] = "true";
testProject.AdditionalProperties["UseUwpTools"] = "false";

// Temporary until new projections flow to tests
testProject.AdditionalProperties["WindowsSdkPackageVersion"] = "10.0.22621.39";
Expand Down
Loading