-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Split tests by method rather than class #45520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a16bc2a
to
3870455
Compare
/azp run dotnet-sdk-public-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
@Evangelink I've been experimenting with splitting our tests into smaller buckets. Even this one had a time out but the dump wasn't collected. Does this look like anything you've seen before? Do I need to enable the additional logging here? Data collector 'Blame' message: The specified inactivity time of 15 minutes has elapsed. Collecting hang dumps from testhost and its child processes. Attachments: The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from. |
Discussing with @nohwnd it seems to be a bug on .NET dump tool, could you please open issue here https://github.com/dotnet/diagnostics |
Created dotnet/diagnostics#5196 to track. |
/azp run dotnet-sdk-public-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
66094fc
to
16d915b
Compare
/azp run dotnet-sdk-public-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run dotnet-sdk-public-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
16d915b
to
944b98b
Compare
944b98b
to
50baef4
Compare
I'm still not sure if we want this. It solves the problem of classes having too many tests and timing out but this split may be too much or run the risk of hitting some sort of character limit.
I ported this manually as I wanted to see how the arm64 leg faired with this change and if it could help us track down the issue causing the timeouts as it would be far fewer tests running per leg.