Skip to content

Split tests by method rather than class #45520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

marcpopMSFT
Copy link
Member

I'm still not sure if we want this. It solves the problem of classes having too many tests and timing out but this split may be too much or run the risk of hitting some sort of character limit.

I ported this manually as I wanted to see how the arm64 leg faired with this change and if it could help us track down the issue causing the timeouts as it would be far fewer tests running per leg.

@marcpopMSFT
Copy link
Member Author

/azp run dotnet-sdk-public-ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcpopMSFT
Copy link
Member Author

@Evangelink I've been experimenting with splitting our tests into smaller buckets. Even this one had a time out but the dump wasn't collected. Does this look like anything you've seen before? Do I need to enable the additional logging here?
_createdump] Gathering state for process 22368
[createdump] Target process is alive
[createdump] thread_get_state(627f7) FAILED (os/kern) invalid argument (4)
[createdump] Failure took 13ms
The active test run was aborted. Reason: Test host process crashed : [createdump] thread_get_state(627f7) FAILED (os/kern) invalid argument (4)
[createdump] Failure took 13ms

Data collector 'Blame' message: The specified inactivity time of 15 minutes has elapsed. Collecting hang dumps from testhost and its child processes.
Data collector 'Blame' message: Data collector caught an exception of type 'System.IO.FileNotFoundException': 'Collect dump was enabled but no dump file was generated.'. More details: Blame: Collecting hang dump failed with error...
Results File: /private/tmp/helix/working/96B108B4/w/A86508FF/e/_dci-macm2-build-013_2025-01-13_18_59_49.trx

Attachments:
/private/tmp/helix/working/96B108B4/w/A86508FF/e/57527c31-fa14-4d1f-ab93-ddde833bffa9/Sequence_86717a59614b4b9cbd87c41593080a68.xml
Test Run Aborted.
Total tests: Unknown
Passed: 43
Total time: 21.9121 Minutes

The active Test Run was aborted because the host process exited unexpectedly. Please inspect the call stack above, if available, to get more information about where the exception originated from.
The test running when the crash occurred:
Microsoft.NET.Build.Tests.GivenThatWeWantToVerifyProjectReferenceCompat.Project_reference_compat_

@Evangelink
Copy link
Member

Discussing with @nohwnd it seems to be a bug on .NET dump tool, could you please open issue here https://github.com/dotnet/diagnostics

@marcpopMSFT
Copy link
Member Author

Created dotnet/diagnostics#5196 to track.

@marcpopMSFT
Copy link
Member Author

/azp run dotnet-sdk-public-ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcpopMSFT
Copy link
Member Author

/azp run dotnet-sdk-public-ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcpopMSFT
Copy link
Member Author

/azp run dotnet-sdk-public-ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcpopMSFT marcpopMSFT force-pushed the marcpopMSFT-portmethodsplit branch from 944b98b to 50baef4 Compare April 7, 2025 17:23
@marcpopMSFT
Copy link
Member Author

#44898 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants